Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix unit test in java 21 #5863

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

wangliang181230
Copy link
Contributor

optimize: fix unit test in java 21
优化:修复单元测试在java21下运行异常的问题。

actions测试成功记录:

all:https://github.com/wangliang181230/seata/actions
build.ymlhttps://github.com/wangliang181230/seata/actions/runs/6272799600
test.ymlhttps://github.com/wangliang181230/seata/actions/runs/6272799601
test-druid.ymlhttps://github.com/wangliang181230/seata/actions/runs/6272799603

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #5863 (4bcecf3) into 2.x (ce2f962) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5863      +/-   ##
============================================
- Coverage     48.91%   48.90%   -0.02%     
+ Complexity     4467     4465       -2     
============================================
  Files           821      821              
  Lines         28641    28641              
  Branches       3571     3571              
============================================
- Hits          14011    14007       -4     
- Misses        13175    13181       +6     
+ Partials       1455     1453       -2     

see 1 file with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM This is where the @EnabledOnJre annotation comes in, and we'll still need to get it to work on jdk17 and above!

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit fd9a70e into apache:2.x Sep 24, 2023
8 checks passed
@wangliang181230 wangliang181230 deleted the test-java21-for-2.x branch September 25, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants